bump golangci-lint to v1.55.2 and fix new lint issues #5941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss
added
area/tooling
skriss
requested review from
tsaarni and
stevesloka
and removed request for
a team
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5941 +/- ##
=======================================
Coverage 78.56% 78.56%
=======================================
Files 139 139
Lines 19614 19615 +1
=======================================
+ Hits 15410 15411 +1
Misses 3901 3901
Partials 303 303
|
skriss
added a commit
to skriss/contour
that referenced
this pull request
Apr 9, 2024
…#5941) Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss
added a commit
that referenced
this pull request
Apr 10, 2024
* bump Go to 1.21.9 * bump Envoy to 1.28.2 * bump golangci-lint to v1.55.2 and fix new lint issues (#5941) Signed-off-by: Steve Kriss <stephen.kriss@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like it addresses whatever the issue is with the linter in #5935